Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/triggers card #514

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Feat/triggers card #514

merged 7 commits into from
Apr 25, 2023

Conversation

boscocg
Copy link
Contributor

@boscocg boscocg commented Apr 20, 2023

[PR Name]

Type of PR

  • - feature

Screenshot 2023-04-20 at 15 19 27

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway-website ❌ Failed (Inspect) Apr 25, 2023 5:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui-storybook ⬜️ Ignored (Inspect) Apr 25, 2023 5:55pm

{t('credential.triggers.title')}
</Typography>
<Stack divider={<Divider />}>
{credential.revocationConditions && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

value={credential.revocationConditions}
/>
)}
{credential.suspensionConditions && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

value={credential.suspensionConditions}
/>
)}
{credential.updateConditions && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit 68c0584 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

@boscocg boscocg marked this pull request as draft April 20, 2023 18:28
@boscocg boscocg marked this pull request as ready for review April 25, 2023 14:08
@boscocg boscocg merged commit 5bc9847 into develop Apr 25, 2023
@boscocg boscocg deleted the feat/triggers-card branch April 25, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants