-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Attribute Error: 'HTTPResponse' object has no attribute 'strict' #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try out newest poetry build to fix bug http requests has no attribute strict
Michionlion
requested changes
May 23, 2023
Specifying urllab3 in pyproject.toml doesn't help with the Requests bug. Delete it
Upgrade Poetry in the workflow/main.yml to the newest version 1.5.0
Michionlion
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's make sure this is fully tested (by installing it locally and running a few assignments through it) and then I think we're good to go.
It works well locally after a few trials |
noorbuchi
approved these changes
Jun 3, 2023
gkapfham
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests Incompatibility Problem
Description
Current Poetry version will return error
To fix this problem, the easiest workaround is to upgrade Poetry over 1.2. Here I upgraded the automatic build of Poetry in
.GitHub/workflow/main.yml
to1.4.2
Linked Issues
More discussions about this error could be found in psf/cachecontrol#292
closes: #00
Type of Change
Contributors