Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For review: Add variable rate slope 1 stablecoin update. #2

Closed
wants to merge 2 commits into from

Conversation

reem
Copy link
Collaborator

@reem reem commented Nov 16, 2023

Same issue with the Metis portion as #1

Copy link

@katiebk katiebk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amending my previous comment

all USDC going from 0.035 -> 0.05 EXCEPT:

  • v3 Base USDbC 0.04 -> 0.05
  • v2 Avalanche USDC 0.04 -> 0.05
  • v2 Ethereum USDC 0.04 -> 0.05
  • v2 Polygon USDC 0.04 -> 0.05

all changes look correct


| Market | Asset | Parameter | Current Value | Recommended Value |
| ------------ | ------ | ------------------ | ------------- | ----------------- |
| Ethereum v2 | USDC | variableRateSlope1 | 0.035 | 0.05 |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this actually needs to be changed then for the hackmd. all v2 USDC current values = 0.04

| Ethereum v3 | USDT | variableRateSlope1 | 0.04 | 0.05 |
| Ethereum v3 | LUSD | variableRateSlope1 | 0.04 | 0.05 |
| Ethereum v3 | FRAX | variableRateSlope1 | 0.04 | 0.05 |
| Avalanche v2 | USDC | variableRateSlope1 | 0.035 | 0.05 |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change here

| Avalanche v3 | USDT | variableRateSlope1 | 0.04 | 0.05 |
| Avalanche v3 | DAI | variableRateSlope1 | 0.04 | 0.05 |
| Avalanche v3 | FRAX | variableRateSlope1 | 0.04 | 0.05 |
| Polygon v2 | USDC | variableRateSlope1 | 0.035 | 0.05 |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change here

@reem
Copy link
Collaborator Author

reem commented Nov 17, 2023

Updated current values in proposal description

Copy link

@ndelzingaro88 ndelzingaro88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for the PR

| --- | --- | --- |
| interestRateStrategy | [0xA9F3C3caE095527061e6d270DBE163693e6fda9D](https://arbiscan.io/address/0xA9F3C3caE095527061e6d270DBE163693e6fda9D) | [0x53b13a6D43F647D788411Abfd28D229C274AfBF9](https://arbiscan.io/address/0x53b13a6D43F647D788411Abfd28D229C274AfBF9) |
| variableRateSlope1 | 4 % | 5 % |
| baseStableBorrowRate | 5 % | 6 % |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the post for the increase in basestableborrowrate? can the base stable rate not below the variable rate slope 1?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are bunch of stablerate additions, might want to double check that is accurate based on hackmd, snapshot, and proposal not mentioning those rates

@reem reem closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants