Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For internal review: add gauntlet renewal AIP #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

For internal review: add gauntlet renewal AIP #5

wants to merge 3 commits into from

Conversation

reem
Copy link
Collaborator

@reem reem commented Nov 28, 2023 •
edited
Loading

Test log output:

[PASS] test_proposalPayments() (gas: 643437)
Logs:
  Gauntlet GHO Balance Change            799999999999999993584000
  Gauntlet aUSDT Balance Change          319995792000
  Insolvency Refund aUSDT Balance Change 480000000000
  GHO Remaining in Collector             536165606593113383046089
  aUSDT Remaining in Collector           597940937340

reem
reem commented Nov 28, 2023
View reviewed changes
...8_AaveV3Ethereum_GauntletAaveRenewal2023/AaveV3Ethereum_GauntletAaveRenewal2023_20231128.sol
*/
contract AaveV3Ethereum_GauntletAaveRenewal2023_20231128 is IProposalGenericExecutor {
address public constant GAUNTLET_STREAMING_BENEFICIARY = 0xD20c9667bf0047F313228F9fE11F8b9F8Dc29bBa;
address public constant GAUNTLET_INSOLVENCY_REFUND = 0x7667095Caa12b79fCa489ff6E2198Ca01fDAe057;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses confirmed with JK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POMWOMI-Escrow-1

ringwraith10
ringwraith10 reviewed Nov 28, 2023
View reviewed changes
Copy link

@ringwraith10 ringwraith10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked decimal points for USDT and GHO, as well as unix timestamps.

How do we claim insolvency refund at end of 2024? (nvm, we control the address)

ringwraith10

This comment was marked as duplicate.

Sign in to view

gauntlet-bot
gauntlet-bot reviewed Nov 29, 2023
View reviewed changes
...8_AaveV3Ethereum_GauntletAaveRenewal2023/AaveV3Ethereum_GauntletAaveRenewal2023_20231128.sol
* - Discussion: https://governance.aave.com/t/arfc-gauntlet-aave-renewal-2023/15380
*/
contract AaveV3Ethereum_GauntletAaveRenewal2023_20231128 is IProposalGenericExecutor {
address public constant GAUNTLET_STREAMING_BENEFICIARY = 0xD20c9667bf0047F313228F9fE11F8b9F8Dc29bBa;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gauntlet-ETH-PUB1

gauntlet-bot
gauntlet-bot approved these changes Nov 29, 2023
View reviewed changes
Copy link

@gauntlet-bot gauntlet-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

reichiang
reichiang approved these changes Nov 29, 2023
View reviewed changes
Copy link

@reichiang reichiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbatch01 pushed a commit that referenced this pull request Dec 7, 2023
@miguelmtzinf @parth-15
Add proposal for Gho Incident Report 20231113 (bgd-labs#109)
157a3fc 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
jbatch01 pushed a commit that referenced this pull request Jan 25, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka
StkGHO Initialization proposal (bgd-labs#170)
1982811 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
jbatch01 pushed a commit that referenced this pull request Jan 25, 2024
@miguelmtzinf @parth-15 @brotherlymite
GHO Stability Module Launch (bgd-labs#169)
0f4c6e7 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringwraith10 ringwraith10 ringwraith10 approved these changes

@gauntlet-bot gauntlet-bot gauntlet-bot approved these changes

@reichiang reichiang reichiang approved these changes

@WatFu WatFu Awaiting requested review from WatFu

@pauljlei pauljlei Awaiting requested review from pauljlei

@danactung danactung Awaiting requested review from danactung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reem @reichiang @gauntlet-bot @ringwraith10