-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing extensions, and the bvconv extension #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks. Let me know when it's merged. |
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 12, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 12, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 13, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 13, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 13, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 13, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 19, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
bclement-ocp
added a commit
to OCamlPro/alt-ergo
that referenced
this pull request
Mar 19, 2024
Use the new "bvconv" typing extension introduced in Gbury/dolmen#208 instead of our own custom builtins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #205
This PR adds a notion of typing extensions, which allow to add new builtins for the typechecking. Fomr the point of view of the ocaml API, these do not add much compared to the already existing
additional_builtins
mechanism. They mainly represent a slightly more structured way to add new builtins. When using thedolmen
binary, these extensions can be activated on the command line, using the new--ext
option.Currently, these is only a single extension: the
bvconv
extension, which adds thebv2nat
andint2bv
functions, as described in #205 (comment)Therefore, examples of smtlib2 problems using either
bv2nat
orint2bv
will now be able to typecheck using the following command-line: