feat: partial liquidations and minor improvements #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's the very commit one would expect to see the night before the audit kicks in. Here we add the logic from `PartialLiquidationBotV3` to the credit facade. This approach has a few important benefits: * it doesn't trigger safe pricing in the collateral check * it allows partial liqudiations during pause * it properly handles fee-on-transfer underlyings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the very commit one would expect to see the night before the audit kicks in.
Here we add the logic from
PartialLiquidationBotV3to the credit facade. This approach has a few important benefits:The PR also contains some general code improvements:
CreditConfiguratorV3's constructor is more consistentfeeInterestis made immutable inCreditManagerV3, which prevents debt manipulation by controller and improves storage packing