Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm install #1521

Closed
oximer opened this issue Jan 17, 2018 · 3 comments
Closed

Npm install #1521

oximer opened this issue Jan 17, 2018 · 3 comments

Comments

@oximer
Copy link

oximer commented Jan 17, 2018

Hey guys,

I noticed that you added two Github repositories as dependencies of this project and this are causing me problems.

When using GitHub as dependencies you don't specify a released build version. Actually you are cloning the master branch. Thus, you never know what is coming for your project.

This is an issue for security.

In my specific scenario this situation is even worse. All the server that I use for building don't have access to internet. Those server have this restriction aiming to guarantee that we have all source code used for building.

Thus, I want to suggest this project to use a release stable version instead of a Github repositories.

@gutoglup
Copy link
Contributor

In the package.json file there are two dependencies that use the github clone. If it is possible to change the repositories to a stable version of npm to correct the problem mentioned.
Also taking advantage of the following repositories have register in the npm.

"react-native-drawer": "https://github.com/GeekyAnts/react-native-drawer",
"react-native-keyboard-aware-scroll-view": "https://github.com/GeekyAnts/react-native-keyboard-aware-scroll-view"

@Jancat
Copy link

Jancat commented Jan 18, 2018

@SupriyaKalghatgi Can you release a patch? I need the fix with a little emergency. Thanks !!

@SupriyaKalghatgi
Copy link
Contributor

Release patch 2.3.7 with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants