-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npm install #1521
Comments
In the package.json file there are two dependencies that use the github clone. If it is possible to change the repositories to a stable version of npm to correct the problem mentioned.
|
gutoglup
added a commit
to gutoglup/NativeBase
that referenced
this issue
Jan 17, 2018
@SupriyaKalghatgi Can you release a patch? I need the fix with a little emergency. Thanks !! |
SupriyaKalghatgi
added a commit
that referenced
this issue
Jan 18, 2018
Release patch 2.3.7 with fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey guys,
I noticed that you added two Github repositories as dependencies of this project and this are causing me problems.
When using GitHub as dependencies you don't specify a released build version. Actually you are cloning the master branch. Thus, you never know what is coming for your project.
This is an issue for security.
In my specific scenario this situation is even worse. All the server that I use for building don't have access to internet. Those server have this restriction aiming to guarantee that we have all source code used for building.
Thus, I want to suggest this project to use a release stable version instead of a Github repositories.
The text was updated successfully, but these errors were encountered: