Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript support for Picker props placeholderStyle #1544

Closed
Jeowulf opened this issue Jan 27, 2018 · 1 comment
Closed

Add TypeScript support for Picker props placeholderStyle #1544

Jeowulf opened this issue Jan 27, 2018 · 1 comment

Comments

@Jeowulf
Copy link

Jeowulf commented Jan 27, 2018

react-native, react and native-base version

react native version 0.52.1, native-base Version 2.3.7

Expected behaviour

Picker placeholderStyle prop supported by TypeScript

Actual behaviour

Missing Type definition

Steps to reproduce (code snippet or screenshot)

In a Project running on TS, give the Picker a prop of placeholderStyle

Screenshot of emulator/device

screen shot 2018-01-27 at 5 46 47 pm

Is the bug present in both ios and android or in any one of them?

Only tested on ios

Any other additional info which would help us debug the issue quicker.

Nothing more specific
akhil-ga added a commit that referenced this issue Jan 29, 2018
@akhil-ga
Fix for issue #1544 (Add TypeScript support for Picker prop placehold…
f02045f 
…erStyle)
SupriyaKalghatgi added a commit that referenced this issue Feb 1, 2018
@SupriyaKalghatgi
Merge pull request #1546 from GeekyAnts/fix/tsSupport/pickerPlaceHold…
482fe2b 
…erStyle

Fix for issue #1544 (Add TypeScript support for Picker prop placehold…
@SupriyaKalghatgi
Copy link
Contributor

Fixed with 2.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jeowulf @SupriyaKalghatgi