Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontVariant (array of enum) not supported from theme files #1637

Closed
hugofelp opened this issue Feb 27, 2018 · 1 comment
Closed

fontVariant (array of enum) not supported from theme files #1637

hugofelp opened this issue Feb 27, 2018 · 1 comment

Comments

@hugofelp
Copy link

react-native, react and native-base version

RN 0.53.3
NB 2.3.9

Expected behaviour

text is rendered with intended styles

Actual behaviour

Application throws an exception

Steps to reproduce (code snippet or screenshot)

Provide an array as value to fontVariant property in any theme file. Example:

import variable from "./../variables/platform";

export default (variables = variable) => {
  const h1Theme = {
    color: variables.textColor,
    fontSize: variables.fontSizeH1,
    lineHeight: variables.lineHeightH1,
    fontWeight: '200',
    fontVariant: ['small-caps']
  };

  return h1Theme;
};

Screenshot of emulator/device

screen shot 2018-02-28 at 11 26 12 am

Is the bug present in both ios and android or in any one of them?

Yes

Any other additional info which would help us debug the issue quicker.

fontVariant expects an array as per documentation - https://facebook.github.io/react-native/docs/text-style-props.html#fontvariant

akhil-ga added a commit that referenced this issue Mar 6, 2018
SupriyaKalghatgi added a commit that referenced this issue Mar 7, 2018
Attempt to fix issue #1637 (fontVariant (array of enum) not supported…
@SupriyaKalghatgi
Copy link
Contributor

Fixed with NB 2.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants