Memory Leak : HybridProvider

[MarkLester10]

Description

When you close the app there is a memory leak in useEffect HybridProvider:

CodeSandbox/Snack link

Private Repo

Steps to reproduce

1. Open the app
2. Close
3. Error in Metro appears

ERROR Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
in HybridProvider (at NativeBaseProvider.tsx:90)

NativeBase Version

3.4.5

Platform

• Android
• CRA
• Expo
• iOS
• Next

Other Platform

No response

Additional Information

Project is using RN 0.68.2

[surajahmed]

@MarkLester10 Thanks for reporting.
We'll look into this. Hope to fix this in the coming release.

[kevindice]

Pretty sure I'm seeing the same issue but with a slightly different message:

    console.error
      Warning: Internal React error: Attempted to capture a commit phase error inside a detached tree. This indicates a bug in React. Likely causes include deleting the same fiber more than once, committing an already-finished tree, or an inconsistent return pointer.
      
      Error message:
      
      TypeError: Cannot read properties of undefined (reading 'remove')
          at children (/Users/kdice/company-redacted/mobile-apps/node_modules/native-base/lib/commonjs/core/hybrid-overlay/HybridProvider.tsx:9:3)
          at disableCSSMediaQueries (/Users/kdice/company-redacted/mobile-apps/node_modules/native-base/lib/commonjs/utils/useResponsiveQuery/ResponsiveQueryProvider.tsx:20:12)
          at children (/Users/kdice/company-redacted/mobile-apps/node_modules/react-native-safe-area-context/jest/mock.js:26:24)
          at children (/Users/kdice/company-redacted/mobile-apps/node_modules/native-base/lib/commonjs/utils/createContext.tsx:9:13)
          at colorModeManager (/Users/kdice/company-redacted/mobile-apps/node_modules/native-base/lib/commonjs/core/NativeBaseProvider.tsx:52:5)

Fills up the Jest output quite a bit.

[reactionic27]

@surajahmed Is there any updates about this issue? I am having same issue in Jest.
My issue is same with @kevindice

[bojackhorseman0309]

I'm having the same issue like @kevindice when running my tests after updating to Expo SDK 46, also using latest Native Base.

Is this already fixed? Did someone found anything?

[kevindice]

My team has been using a yarn patch on it so far:

(apologies for the screenshot, am on mobile)

edit:

Filename: /.yarn/patches/native-base-npm-3.4.28-a8ecceae4d.patch

diff --git a/lib/commonjs/core/color-mode/hooks.js b/lib/commonjs/core/color-mode/hooks.js 
 index 76751c096376cd2097b84b220fc11bb82be1b53c..ebe26ce20a99c97790aca157fcae80c1c7e5496e 100644 
 --- a/lib/commonjs/core/color-mode/hooks.js 
 +++ b/lib/commonjs/core/color-mode/hooks.js 
 @@ -56,7 +56,7 @@ const useAppState = () => { 
          } else { 
            // React Native >= 0.65 
            // @ts-ignore:next-line ignoring ts error as devDependency contains "@types/react-native" < 0.65 
 -          subsription.remove(); 
 +          subsription?.remove(); 
          } 
        }; 
      }

[bojackhorseman0309]

@kevindice Ohhhh yeah indeed, just did a quick change on the file and it indeed doesn't show anymore. Thanks for the quick response.

I saw that you reviewed this PR that introduce that code #5359

If the fix is to use the optional chaining, why it hasn't been done? Is there a more deeper issue with this? Or is it that it just haven't been done?

[kevindice]

@kevindice Ohhhh yeah indeed, just did a quick change on the file and it indeed doesn't show anymore. Thanks for the quick response.

I saw that you reviewed this PR that introduce that code #5359

If the fix is to use the optional chaining, why it hasn't been done? Is there a more deeper issue with this? Or is it that it just haven't been done?

Honestly not sure

[r3dm1ke]

Is there an update for this one? Can I open a PR that adds optional chaining?

[bojackhorseman0309]

Not at all, I created my tests around not triggering this, but it's still there.

…

________________________________ From: Michael Krasnov ***@***.***> Sent: Wednesday, April 26, 2023 1:28:24 PM To: GeekyAnts/NativeBase ***@***.***> Cc: Bojack Horseman ***@***.***>; Comment ***@***.***> Subject: Re: [GeekyAnts/NativeBase] Memory Leak : HybridProvider (Issue #5547) Is there an update for this one? Can I open a PR that adds optional chaining? — Reply to this email directly, view it on GitHub<#5547 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIK65C37WG5ZB6CBXI4RMWDXDFZNRANCNFSM6AAAAAAR5LQCMM>. You are receiving this because you commented.Message ID: ***@***.***>