Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast component improvements - onClose callback #1392

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Toast component improvements - onClose callback #1392

merged 3 commits into from
Feb 2, 2018

Conversation

gcorreaalves
Copy link
Contributor

@gcorreaalves gcorreaalves commented Nov 23, 2017 •
edited
Loading

  • Run the onClose callback immediately after it closes and not before
  • Run the onClose callback also when it closes automatically

@joshhornby
Copy link

If the merge conflicts are fixed can this be merged? @akhil-geekyants

@gcorreaalves gcorreaalves force-pushed the improvement/toast-onclose-callback branch from 6c54d36 to 3f58e7f Compare December 20, 2017 15:19
@gcorreaalves
Copy link
Contributor Author

Hi @joshhornby I solved the conflicts. Now, I've been waiting for some answer or the acceptance of my improvements.

@SupriyaKalghatgi SupriyaKalghatgi merged commit 950022a into GeekyAnts:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcorreaalves @joshhornby @SupriyaKalghatgi