Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1423 #1424

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Fix for issue #1423 #1424

merged 2 commits into from
Dec 21, 2017

Conversation

akhil-ga
Copy link
Contributor

@akhil-ga akhil-ga commented Dec 6, 2017

Issue - SwipeRow not exported in TypeScript definition
Added missing export SubTitle in typescript declaration file

@akhil-ga akhil-ga added the PR label Dec 6, 2017
@SupriyaKalghatgi SupriyaKalghatgi merged commit e4674f5 into development Dec 21, 2017
@SupriyaKalghatgi SupriyaKalghatgi deleted the fix/typescriptDeclaration/swipeRow branch January 4, 2018 13:20
@Dome-GER
Copy link

It has to be Subtitle instead of SubTitle since the component itself is called Subtitle, hasn't it?
Currently, you'll get:

[...] node_modules/native-base/index"' has no exported member 'Subtitle'

akhil-ga added a commit that referenced this pull request Feb 14, 2018
@akhil-ga
Changed 'SubTitle' to 'Subtitle' in index.d.ts
7c0496c 
Fix based on issuecomment
#1424 (comment)
@akhil-ga akhil-ga mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivrajkumar shivrajkumar Awaiting requested review from shivrajkumar

@SupriyaKalghatgi SupriyaKalghatgi Awaiting requested review from SupriyaKalghatgi

Assignees

@SupriyaKalghatgi SupriyaKalghatgi

@shivrajkumar shivrajkumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhil-ga @Dome-GER @SupriyaKalghatgi @shivrajkumar