Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY-up ToastContainer #1562

Merged
merged 3 commits into from
Feb 16, 2018
Merged

DRY-up ToastContainer #1562

merged 3 commits into from
Feb 16, 2018

Conversation

alexrussell
Copy link
Contributor

  • Fix broken eslintrc file
  • Refactor ToastContainer to DRY-up calls to Animated.timing by:
    • Removing multiple calls to setTimeout by extracting the conditional to a variable
    • Passing references to this.closeToast in the timeout rather than redefining the function's body in the timeout callback
  • Save a timeout when fading the toast out by using the Animated.timing completion callback rather than using setTimeout with a 500ms delay.

…lso save a timeout when fading the toast out by using the `Animated.timing` completion callback.
@SupriyaKalghatgi SupriyaKalghatgi merged commit 4cc526c into GeekyAnts:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants