Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picker has been extracted from react-native core #3163

Closed
wants to merge 3 commits into from
Closed

Picker has been extracted from react-native core #3163

wants to merge 3 commits into from

Conversation

Preeternal
Copy link

The issue
Could you please to review?

@Preeternal Preeternal changed the title initial commit Picker has been extracted from react-native core May 27, 2020
@Preeternal
Copy link
Author

replaced community-picker into peerDependencies

@lifenautjoe
Copy link

Can someone please merge and release this? Blocking as it prevents app instantiation with

 Invariant Violation: Tried to register two views with the same name AndroidDropdownPicker

@alexandrtovmach
Copy link
Contributor

@Preeternal I'm not sure that's moving required dependency to peerDependencies is good idea

#3230 it's duplicate, but it used "normal" dependencies, so my vote for that

@Preeternal
Copy link
Author

Can someone please merge and release this? Blocking as it prevents app instantiation with

 Invariant Violation: Tried to register two views with the same name AndroidDropdownPicker

Reason is in importing AndroidDropdownPicker twice from 2 places. Could you please to review your dependencies list and imports from RN?

@Preeternal
Copy link
Author

@Preeternal I'm not sure that's moving required dependency to peerDependencies is good idea

#3230 it's duplicate, but it used "normal" dependencies, so my vote for that
But someone probably will want to use community picker and native-base in own project same time. It will return error described by @lifenautjoe

@Preeternal Preeternal closed this Oct 2, 2020
@Preeternal Preeternal deleted the community-picker branch October 2, 2020 17:24
@Preeternal Preeternal restored the community-picker branch October 2, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgane1806 morgane1806 morgane1806 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Preeternal @lifenautjoe @alexandrtovmach @morgane1806 @hanykumar