Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tip: @actions/artifact added methods to delete artifacts #19

Closed
muzimuzhi opened this issue Jan 18, 2024 · 3 comments · Fixed by #24
Closed

Tip: @actions/artifact added methods to delete artifacts #19

muzimuzhi opened this issue Jan 18, 2024 · 3 comments · Fixed by #24

Comments

@muzimuzhi
Copy link

See

It seems to me then implementation in current repo could be simplified, once @actions/artifact ships a new release.
@GeekyEggo
Copy link
Owner

GeekyEggo commented Jan 19, 2024 •
edited
Loading

This is really helpful, and may remove the need for the new token parameter. Thank you for bringing this to my attention!

@AlvinSchiller AlvinSchiller mentioned this issue Feb 5, 2024
Merged
@muzimuzhi
Copy link
Author

muzimuzhi commented Feb 6, 2024 •
edited
Loading

actions/artifact has just released v2.1.1 which ships with the new method artifact.deleteArtifact(), see https://www.npmjs.com/package/@actions/artifact/v/2.1.1 and the doc for new method.

Note that as I'm writing this there's no tag @actions/artifact@2.1.1 in repo https://github.com/actions/toolkit yet, but the new version is indeed uploaded to npm hence useable to downstream actions, e.g., actions/download-artifact@9ac5cad.

Update: I reported actions/toolkit#1658.

@s-weigand s-weigand mentioned this issue Mar 15, 2024
Merged
GeekyEggo pushed a commit that referenced this issue Mar 18, 2024
@s-weigand
refactor: use @actions/artifact (#24) - closes #19, #21
7467c3c 
* Added @actions/artifact as dependency
* Replace ArtifactClient with DefaultArtifactClient from @actions/artifact
* Build dist
* Deprecate token argument to action
@GeekyEggo
Copy link
Owner

GeekyEggo commented Mar 18, 2024 •
edited
Loading

This is now resolved with geekyeggo/delete-artifact@v5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use @actions/artifact s-weigand/delete-artifact
2 participants
@GeekyEggo @muzimuzhi