-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Error related fixes #10
Conversation
rotexdegba
commented
May 22, 2020
- Added code to guard against some type errors in \Ginfo\OS\Windows
@rotexdegba can you explain how to reproduce the problems? |
I am running on Windows 10 with all errors, warnings and notices turned on in PHP. I think it might have been before I ran Set-ExecutionPolicy -ExecutionPolicy . The ->setType($volume['FileSystem'] ) was blowing up for my dvd drive as it contained null and setType was expecting a string. The other checks are defensive and don't adversely affect Ginfo\OS\Windows . |
@rotexdegba can you check master branch which last changes? i don't have dvd drive to check it myself. |
Here's one error I am currently getting on windows with the latest master branch code, that would have been prevented by one of the changes in this pull request:
|
I can't reproduce the problem. Can you execute the powershell code and show me the result? Get-WmiObject -Class Win32_OperatingSystem LastBootUpTime |
|
Thanks a lot! I got it. That's problem with negative offset. |