Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

771 bugerror writing cost when we have resources that are not new build and not eligible for retirement #796

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Nov 25, 2024

Description

Addresses #771 by adding a default value (0.0) for the final fixed cost calculation: eCFix = sum(value.(EP[:eCFix][Y_ZONE])), applied when the set Y_ZONE is empty.

What type of PR is this? (check all applicable)

  • Bug Fix

Related Tickets & Documents

Fixes #771.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

The test suite now includes a new test case with two zones, one of which has no generators.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo added the bug Something isn't working label Nov 25, 2024
Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved !!!

lbonaldo and others added 6 commits December 3, 2024 15:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lbonaldo lbonaldo force-pushed the 771-bugerror-writing-cost-when-we-have-resources-that-are-not-new-build-and-not-eligible-for-retirement branch from 67821e9 to 84dcf3e Compare December 3, 2024 20:03
@lbonaldo
Copy link
Collaborator Author

lbonaldo commented Dec 3, 2024

Thanks @sambuddhac

@lbonaldo lbonaldo merged commit d201184 into develop Dec 3, 2024
9 checks passed
@lbonaldo lbonaldo deleted the 771-bugerror-writing-cost-when-we-have-resources-that-are-not-new-build-and-not-eligible-for-retirement branch December 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants