Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings flag for new LDS constraints activation #801

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Dec 3, 2024

Description

This PR introduces a new settings flag to provide flexibility in activating new long-duration storage constraints (PR #781).

What type of PR is this? (check all applicable)

  • Feature

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Using the "3_three_zones_w_co2_capture" example case and enabling LDS on storage resources.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from filippopecci December 3, 2024 17:13
@lbonaldo lbonaldo changed the title Ldes constr optional Settings flag for new LDS constraints activation Dec 3, 2024
@lbonaldo lbonaldo marked this pull request as draft December 3, 2024 17:17
@lbonaldo lbonaldo marked this pull request as ready for review December 3, 2024 20:34
@lbonaldo lbonaldo force-pushed the ldes-constr-optional branch from f5672c7 to cb2ff55 Compare December 3, 2024 20:34
@lbonaldo lbonaldo added the enhancement New feature or request label Dec 3, 2024
@lbonaldo lbonaldo added this to the v0.4.2 milestone Dec 4, 2024
@lbonaldo lbonaldo requested a review from RuaridhMacd December 5, 2024 15:23
@lbonaldo lbonaldo force-pushed the ldes-constr-optional branch from d3013b1 to c0599d7 Compare December 5, 2024 18:49
@lbonaldo lbonaldo merged commit cccab41 into GenXProject:develop Dec 23, 2024
9 checks passed
@lbonaldo lbonaldo deleted the ldes-constr-optional branch December 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants