Instructions fixes #104
Merged
Instructions fixes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cleaned up the drawSubgoal function (the else condition wasn't necessary). This way the code will be a bit more clear.
|
Thanks for doing this. Heads up: best practice for commits is make them small and often so that they're easier for a 3rd party to understand what was done. Commit messages are important too. An arbitrary example: "Add submit buttons There was previously no submit button so one was added in order to allow the form to submit properly" (1st line as a header, rest of lines giving more details on the commit) |
|
Thanks for your feedback! I'll keep this in mind in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request template
about: GenderMag Recorders Assistant project
What does this implementation fix? Explain your changes.
Addresses issues related to unclear instructions or documentation.
Does this close any open issue? (Give issue id from issue tracker)
Update text for adding action and subgoal to improve clarity #97, Add detailed instructions on screenshot/highlight #96, Update team name field #95, Explain what a 'gendermag session' is #93, Remove redundant text in introduction #92, Intro page 'click here' link can be confusing #91
Did you test on Mac and Windows?
Only Mac.
Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?
Yes.
If possible, provide a screenshot of the functionality.
I apologize that this also contains Diana's commit. I had trouble making a "clean" branch in our remote repo.