Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for StanModules + cleanup #326

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented May 20, 2024

Closes #324

Decided to opt for a warning as I'm not sure it warranted a full error to be thrown.

I also took this opportunity to remove the inits and prior arguments to StanModule. These were based on an older design and are not currently used at all as both inits and priors are now handled by the Parameter / ParameterList system instead. I think this just got overlooked so am cleaning it up.

Copy link
Contributor

Unit Tests Summary

  1 files   42 suites   8m 17s ⏱️
137 tests 106 ✅ 31 💤 0 ❌
928 runs  897 ✅ 31 💤 0 ❌

Results for commit e8ab11e.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Grid 💔 $196.11$ $+17.96$ $0$ $0$ $0$ $0$
GridPrediction 💔 $121.59$ $+2.09$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💔 $28.23$ $+2.08$ GridFixed_bug_has_been_fixed
Grid 💔 $72.78$ $+8.63$ GridObservered_Constructs_correct_quantities
Grid 💔 $36.57$ $+4.87$ GridPopulation_works_as_expected_for_GSF_models
Grid 💔 $28.11$ $+2.09$ GridPopulation_works_as_expected_for_Longitudinal_models
GridPrediction 💔 $98.89$ $+1.73$ GridPrediction_works_as_expected_for_Survival_models
StanModule 👶 $+0.01$ StanModule_throws_a_warning_if_non_empty_string_generates_empty_object

Results for commit aa6c3b9

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/Grid.R                              27       1  96.30%   170
R/GridEven.R                          32       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       123       8  93.50%   141-143, 193, 197, 239, 285, 291
R/JointModelSamples.R                 59       0  100.00%
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalGSF.R                   77       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           36       0  100.00%
R/LongitudinalSteinFojo.R             70       5  92.86%   143-147
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            236       8  96.61%   480, 576, 588-606
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalGSF.R                51       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          48       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/brier_score.R                      166       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          30       3  90.00%   51, 394, 444
R/link_generics.R                     10       2  80.00%   59, 76
R/settings.R                          12      12  0.00%    55-69
R/utilities.R                        143       1  99.30%   13
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               2769     106  96.17%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  -------
R/StanModule.R       -3       0  -0.06%
TOTAL                -3       0  -0.00%

Results for commit: e8ab11e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gowerc gowerc merged commit 9d2ccdc into main May 21, 2024
22 checks passed
@gowerc gowerc deleted the feature/324-stanmodule-error branch May 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StanModule error handling
2 participants