-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logit-Normal parameterisation for GSF Phi #375
Conversation
Code Coverage Summary
Diff against main
Results for commit: eceb927 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 154 suites 6m 28s ⏱️ Results for commit eceb927. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit ab12707 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to improve the docs, otherwise looks good @gowerc
Closes #374
A bit messy just because the GSF distribution is used all over the place so had to edit a lot of testing locations.
The implementation is slightly different compared to the other parameters. This is because Stan doesn't have a native logit-normal distribution. Some of their articles recommend implementing logit-normal via:
Problem is if you do it this way you need to apply a Jacobian adjustment which I didn't want to mess around with. So to avoid that instead of having
phi
as the parameter I havephi_logit
as the parameter (thus placing the prior onphi_logit
) and then transform it to the required value viaphi = inv_logit(phi_logit)