Improvements finish filtering#226 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mmahdigh
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Let's use src/app/categories/[categoryId]/pairwise-ranking/vote-submitted/page.tsx for this one too. They are fairly identical. Use a prop for the difference in the on-click behavior of the continue button.
mmahdigh
reviewed
Jul 30, 2024
| ); | ||
| } catch (e) { | ||
| console.error('error on sending tx:', e); | ||
| } finally { | ||
| setAttestUnderway(false); |
There was a problem hiding this comment.
Removing this, if for any reason, the attestation doesn't go through and faces an error, users are going to be stuck with the Submitting vote modal thinking that it's still in progress under the hood.
mmahdigh
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-07-25.13-09-46.mp4