fix requests_args usage for multiple methods #518

avant1 · 2022-06-09T11:10:03Z

request_args are passed twice in _get_data() for some methods:

directly as **self.requests_args
via **kwargs

This leads to the following error:

  File "/usr/local/lib/python3.9/site-packages/pytrends/request.py", line 527, in suggestions
    req_json = self._get_data(
  File "/usr/local/lib/python3.9/site-packages/pytrends/request.py", line 138, in _get_data
    response = s.get(url, timeout=self.timeout, cookies=self.cookies,
TypeError: requests.sessions.Session.get() got multiple values for keyword argument 'headers'

This PR fixes #448, fixes #513

avant1 · 2022-06-09T11:11:46Z

pytrends/test_trendReq.py

+            'User-Agent': 'pytrends',
+        }}
+        pytrend = TrendReq(requests_args=requests_args)
+        pytrend.build_payload(kw_list=['bananas'])


I think this call is not needed, but other tests have it, so I left it here too.

fix requests_args usage for multiple methods

b8a862d

avant1 commented Jun 9, 2022

View reviewed changes

emlazzarin merged commit 706975c into GeneralMills:master Jun 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix requests_args usage for multiple methods #518

fix requests_args usage for multiple methods #518

avant1 commented Jun 9, 2022 •

edited

Loading

avant1 Jun 9, 2022

fix requests_args usage for multiple methods #518

fix requests_args usage for multiple methods #518

Conversation

avant1 commented Jun 9, 2022 • edited Loading

avant1 Jun 9, 2022

Choose a reason for hiding this comment

avant1 commented Jun 9, 2022 •

edited

Loading