Adds Multirange Interest Over Time #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no experience with VCR.py and writing tests for python, so I didn't write any for the PR. Maybe someone else can add them instead? |
|
If you look at the tests that exist the pattern should be relatively easy to follow. Are you able to get the current tests running?
…On Fri, Dec 2 2022 at 15:29, Magico Martinez < ***@***.*** > wrote:
I have no experience with VCR.py and writing tests for python, so I didn't
write any for the PR. Maybe someone else can add them instead?
—
Reply to this email directly, view it on GitHub (
#552 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAIWU4ONIQMRMYA6XLIRXSTWLJL2LANCNFSM6AAAAAASSIS2FY
).
You are receiving this because you are subscribed to this thread. Message
ID: <GeneralMills/pytrends/pull/552/c1335812599 @ github. com>
|
|
@emlazzarin Ok, I've managed to add a couple of tests for the new |
|
Just checking on this. Can this be merged or is it missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Google Trends you can compare two different timeframes for two completely different keywords (or the same keyword). For example: https://trends.google.com/trends/explore?date=2022-03-28%202022-04-01,2021-04-26%202021-04-30&geo=US,US&q=oscars%202022,oscars%202021
This can be particularly useful if you're trying to compare search interest for the same keyword year on year. For example: https://trends.google.com/trends/explore?date=2022-01-01%202022-01-30,2021-01-01%202021-01-30&geo=US,US&q=pizza,pizza
This pull requests adds a new
multirange_interest_over_timethat allows two different timeframes to be compared. This pull request solves issue #532.