-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the two-step grid reading when source is a matrix #3510
Conversation
See #3408 for background. Need to add this to the repo to debug in Xcode.
Grid headers read via matrices must still remember they came from a matrix since when GMT_Read_Data is called a second time to get the data they still need to fall into that method.
I have made a few changes. First, I am parsing the full name and get the various items. For now I am only checking direction and return the object ID. I also made a small change that when we check for the validity of a given object I ignore if it has been used before (it has). I added @seisman example C code as well and two tests (with and without shading) which both passes. All other tests pass as well. There are more simplifications that can be done in gmt_api.c but I want to do that very carefully... |
Closes #3408. |
Description of proposed changes
See #3408 for the initial problem. Here is what goes wrong:
Time to implement a new scheme that extracts the information directly from the filename.
Closes #3408.