Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GMT_keyword_update to false in gmt_begin #5178

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR implements @PaulWessel's suggestion to use gmt_M_memset on GMT_keyword_updated to fix the issue summarized in this comment.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@PaulWessel
Copy link
Member

Did it actually work?

@maxrjones
Copy link
Member Author

The minimal example that @seisman posted is fixed, but some other issues show up in the PyGMT tests. I will post over in the PyGMT issue for feedback.

@PaulWessel
Copy link
Member

OK, since this helped and is surely the correct way to initialize memory (regardless if there are more problems found), please add me as reviewer and I will approve.

@maxrjones maxrjones requested a review from PaulWessel April 28, 2021 22:19
@maxrjones maxrjones merged commit a6980cb into master Apr 28, 2021
@maxrjones maxrjones deleted the gmt-keywords-update branch April 28, 2021 22:48
@maxrjones maxrjones mentioned this pull request May 3, 2021
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants