Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GMT_RGBchart.sh by only producing tabloid size in modern mode #6527

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR simplifies the script for GMT colors to only produce a single size using modern mode (tabloid). Although there is now only a single button to download the tabloid output, users can download/modify the modern mode script to produce a figure of any size.

Prerequisite of #6356.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones added the documentation Improve documentation label Apr 5, 2022
@maxrjones maxrjones requested review from PaulWessel and a team April 5, 2022 21:45
@maxrjones maxrjones merged commit 31d7f95 into master Apr 6, 2022
@maxrjones maxrjones deleted the simplify-GMT_RGBchart branch April 6, 2022 15:50
@seisman
Copy link
Member

seisman commented Apr 12, 2022

FYI, test doc/scripts/GMT_RGBchart.sh fails on Linux/macOS/Windows, likely due to the changes in this PR.

@maxrjones
Copy link
Member Author

FYI, test doc/scripts/GMT_RGBchart.sh fails on Linux/macOS/Windows, likely due to the changes in this PR.

The issue is that #6548 reverted the changes to the RGB files made in this PR as shown by the dvc diff output below. We should come up with a way to prevent this situation, but to fix the problem:

  1. Remove GMT_RGBchart_a4, GMT_RGBchart_letter, and GMT_RGBchart_tabloid from doc/scipts/images.
  2. Copy the passing output from the GMT_RGBchart test to doc/scripts/images
  3. dvc add doc/scripts/images
  4. git commit doc/scripts/images.dvc
  5. dvc push
  6. git push to a PR
dvc diff 31d7f9544fd0ffb60aaa3d359a99a96a992df647 129849b4bcf7614313313c550492572089b7157e                                                                                          
Added:                                                                                                        
    doc/scripts/images/GMT_RGBchart_a4.ps                                                                     
    doc/scripts/images/GMT_RGBchart_letter.ps                                                                 
    doc/scripts/images/GMT_RGBchart_tabloid.ps                                                                
    doc/scripts/images/GMT_seamount_azim.ps                                                                   
    doc/scripts/images/GMT_seamount_psi.ps                                                                    
    doc/scripts/images/GMT_seamount_slide.ps                                                                  
    doc/scripts/images/GMT_seamount_specs.ps                                                                  
    doc/scripts/images/GMT_seamount_u0.ps                                                                     
                                                                                                              
Modified:                                                                                                     
    doc/scripts/images/                                                                                       
    doc/scripts/images/GMT_RGBchart.ps
    doc/scripts/images/GMT_seamount_cum_inc.ps
    doc/scripts/images/GMT_seamount_flux.ps
    doc/scripts/images/GMT_seamount_prisms.ps
    doc/scripts/images/GMT_seamount_types.ps
    test/baseline/potential/
    test/baseline/potential/admittance.ps
    test/baseline/potential/firmoviscous.ps
    test/baseline/potential/firmoviscous2.ps
    test/baseline/potential/flex_inplane.ps
    test/baseline/potential/flexure_e.ps
    test/baseline/potential/flexure_en.ps
    test/baseline/potential/flexure_gl.ps
    test/baseline/potential/flexure_ve.ps
    test/baseline/potential/growth_g.ps
    test/baseline/potential/gseamounts.ps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants