-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from NEP 029 to SPEC 0 #2863
Comments
OK, reading more about NEP 29 and SPEC 0. Here is what NEP 29 recommends:
Here is what SPEC 0 recommends:
They're similar but with some differences:
If we follow SPEC 0, then currently the minimum supported versions will be:
|
Looking at the PyPI download stats at https://pypistats.org/packages/pygmt, it seems like Python 3.9 usage is hovering at about 10-30% in the past 3 months, so not an insignificant fraction. Python 3.10 does seem to be the highest at >50% usually.
We're going to pin to Otherwise, no strong opinions on moving to SPEC 0, and if most of us agree, we can probably move on to implementing the minimum pins. That said, I would maybe suggest that we delay implementation of this to PyGMT v0.12.0, to have a bit of a transition period? |
Sounds reasonable. |
Here are a few points in my mind:
|
IPython is also listed at https://scientific-python.org/specs/spec-0000/, and is marked as an optional dependency of PyGMT here: Line 46 in 4b7cb2a
Do we need to pin to a minimum version of IPython too? If so, we should be on |
I prefer not to pin IPython since it's not heavily used by PyGMT. |
Following [SPEC 0](https://scientific-python.org/specs/spec-0000/) policy where Python 3.9 should be dropped in 2023 quarter 4. Supersedes PR #2487. Address #2863.
Ok let's go with not pinning IPython then, less work having to update the minimum pin every release. |
The NEP 029 page has a note says:
I haven't read SPEC 0 carefully, but I think we should migrate from NEP 029 to SPEC 0.
The text was updated successfully, but these errors were encountered: