Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "full test" section from installation guide #1206

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 12, 2021

Description of proposed changes

  • Remove the "Full test" section since it's no longer valid after
    migrating baseline images to dvc
  • Add a simple script to test the install. If it works, at least
    we know that the coast function, GSHHG data and gs work as expected.

Fixes #1200

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Changes in this PR:

- Remove the "Full test" section since it's no longer valid after
  migrating baseline images to dvc
- Add a simple script to test the install. If it works, at least
  we know that the coast function, GSHHG data and gs work as expected.
@seisman seisman added the documentation Improvements or additions to documentation label Apr 12, 2021
@seisman seisman added this to the 0.4.0 milestone Apr 12, 2021
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Apr 13, 2021
@seisman seisman changed the title Remove the 'full test' section from installation guide Remove the "full test" section from installation guide Apr 14, 2021
@seisman seisman merged commit d41618c into master Apr 14, 2021
@seisman seisman deleted the test-install branch April 14, 2021 04:59
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…gTools#1206)

- Remove the "Full test" section since it's no longer valid after
  migrating baseline images to dvc
- Add a simple script to test the install. If it works, at least
  we know that the coast function, GSHHG data and gs work as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Full test" section from the installation guide
2 participants