Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand table-like input options for xyz2grd #1566

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Expand table-like input options for xyz2grd #1566

merged 4 commits into from
Oct 5, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 3, 2021 •
edited by weiji14
Loading

Description of proposed changes

Support syntax like xyz2grd(x=x, y=y, z=z)

Continuation of #635 and #636.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the enhancement Improving an existing feature label Oct 3, 2021
@seisman seisman added this to the 0.5.0 milestone Oct 3, 2021
weiji14
weiji14 reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Will's PR at #1506 might take a while, could you cherry-pick fda29eb into this PR so that we definitely have it for PyGMT v0.5.0? Thanks!

pygmt/src/xyz2grd.py Show resolved Hide resolved
@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer skip-changelog Skip adding Pull Request to changelog labels Oct 4, 2021
@weiji14
Copy link
Member

weiji14 commented Oct 4, 2021

I added the skip-changelog label since xyz2grd was wrapped in #636 and wasn't in the previous PyGMT v0.4.1 release, so no need to double-up on changelog entries in PyGMT v0.5.0.

@seisman seisman merged commit 3c908aa into main Oct 5, 2021
@seisman seisman deleted the xyz2grd-table-like branch October 5, 2021 00:13
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 5, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Expand table-like input options for xyz2grd (GenericMappingTools#1566)
2faf05f 
* Expand table-like input options for xyz2grd
* Move xyz2grd to the tabular data section
* Compact code for arg_str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @weiji14 @maxrjones