Use alias long-form for grdimage, text, and psconvert tests #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
added
maintenance
seisman
approved these changes
Oct 5, 2021
seisman
added
the
final review call
weiji14
reviewed
Oct 5, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
willschlitzer
approved these changes
Oct 5, 2021
weiji14
approved these changes
Oct 5, 2021
|
I would like to merge this, but what is the expected status that still needs to be reported? |
The codecov check seems to be stuck for some reason. I think you can just squash and merge as an admin, since the code coverage shouldn't have changed anyway. |
|
Do we still have to wait to merge this PR @GenericMappingTools/pygmt-maintainers ? |
What do you mean? This PR was already merged 3 months ago. |
seisman
removed
the
final review call
|
Ah sorry, was confused by the final review call @seisman . |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…appingTools#1570) * Use alias long-form for grdimage, text, and psconvert tests * Remove unnecessary psconvert test Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR modifies the tests for grdimage, text, and psconvert to use the long-form of aliases so that pytest results are not diluted by the resultant syntax warnings.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version