Wrap binstats #1652
Merged
Wrap binstats #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Apr 18, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 6, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 7, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 30, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jun 1, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jun 8, 2022
seisman
approved these changes
Jun 8, 2022
seisman
approved these changes
Jun 8, 2022
seisman
added
the
final review call
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
@GenericMappingTools/pygmt-maintainers Hopefully someone else can give this PR a final review. |
maxrjones
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
Great work, @willschlitzer!
The only important comment here is to include @capitals.gmt in the download_test_data function since that's used for caching the files for the CI.
I agree with #1652 (comment) that the output to file option can be added later since it's more similar to #896 than #1536.
There's some work that needs to be done for managing required arguments, but I think we need some more consistency regarding that throughout the library and it's not a reason to hold this feature back.
| Test binstats with no set outgrid. | ||
| """ | ||
| temp_grid = binstats( | ||
| data="@capitals.gmt", |
There was a problem hiding this comment.
Can you add this to pygmt.helpers.testing.download_test_data?
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
willschlitzer
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
*Wrap gmtbinstats function *Add test_binstats.py *Add binstats to API index *Add remote files "@capitals.gmt" to cached files Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Max Jones <meghanj@alum.mit.edu>
This was referenced Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the GMT module
gmtbinstats.