-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in cylindrical projection examples #2035
Fix typos in cylindrical projection examples #2035
Conversation
Requesting a review from the original author @willschlitzer (in PR #727). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think your understanding is correct. If you like, please also submit a fix to the upstream GMT repository. |
@yvonnefroehlich I've sent you an invitation to join in the GenericMappingTools/pygmt-contributors. After joining in this team, you will have write permission to the pygmt repository, so you can create branches in the pygmt repository instead of in your own fork. |
I'm looking at the upstream GMT documentation and this example. I think this example can be further improved in the following ways:
|
Thanks for inviting me to the GenericMappingTools organization! 😊 Very happy to joint the pygmt-contributors team! 😊
This means I finish the already opened PRs via my fork, and for all new PRs I create a branch directly in the PyGMT repro and open a PR from there, correct? |
I agree with you on all three points. My impression is that the PyGMT documentation for the projections is partly a bit shorten compared to the upstream GMT documentation. Should I open a new PR to improve the PyGMT documentation for the UTM projection regading these three points, or do you prefer that this is also handled in this PR? |
My vote it to leave this PR with the current changes and open up a separate one for the UTM documentation. |
Yes.
I'm OK with a separate PR. |
Description of proposed changes
This PR aims to fix a few typos in the cylindrical projection examples.
I am not totally sure about the second paragraph of the explanation of the UTM projection, see
https://www.pygmt.org/dev/projections/cyl/cyl_universal_transverse_mercator.html?highlight=10%20away
Maybe it is
... less than 10° away ...
in the last line (the unit, probably [the] degree [sign], is missing)?However, there is also no unit in the equivalent GMT documentation, see
https://docs.generic-mapping-tools.org/dev/cookbook/map-projections.html?highlight=10%20away#universal-transverse-mercator-utm-projection-ju-ju.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version