Add intro tutorial section for creating contour map #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
changed the title
6 tasks
seisman
reviewed
Sep 24, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Oct 14, 2022
seisman
reviewed
Oct 20, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Oct 20, 2022
weiji14
reviewed
Oct 20, 2022
examples/get-started/contour-map.py
Outdated
Comment on lines
116
to
118
| # 1. Change the resolution of the grid file to either "01m" (lower resolution) | ||
| # or "15s" (higher resolution). Note that higher resolution grids will have | ||
| # larger file sizes. |
There was a problem hiding this comment.
Maybe link to https://www.generic-mapping-tools.org/remote-datasets/earth-relief.html#usage so users know what are the possible spatial resolutions, and mention explicitly that 01m stands for 1 arc minute (some people might think it's 1 meter).
weiji14
added
the
final review call
|
Ping @willschlitzer to finalize this PR so that we can merge it. |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
Oct 31, 2022
weiji14
changed the title
weiji14
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Looks good, thanks @willschlitzer! Just need to comment that pull_request: line in .github/workflows/cache_data.yaml as mentioned in https://github.com/GenericMappingTools/pygmt/pull/2126/files#r1008968590 before merging.
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ols#2126) Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a second section to the Intro to PyGMT tutorial. It covers retrieving and plotting Earth relief data, adding a color palette and color bar, and plotting contour lines.
Preview at https://pygmt-dev--2126.org.readthedocs.build/en/2126/get-started/contour-map.html
Addresses #770
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version