Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline example for coast #2142

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Add inline example for coast #2142

merged 5 commits into from
Oct 7, 2022

Conversation

willschlitzer
Copy link
Contributor

Addresses #1957

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the documentation Improvements or additions to documentation label Oct 4, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Oct 4, 2022
@willschlitzer willschlitzer self-assigned this Oct 4, 2022
@willschlitzer willschlitzer mentioned this pull request Oct 4, 2022
Open
22 tasks
seisman
seisman reviewed Oct 5, 2022
View reviewed changes
pygmt/src/coast.py Outdated Show resolved Hide resolved
seisman
seisman reviewed Oct 5, 2022
View reviewed changes
pygmt/src/coast.py Outdated Show resolved Hide resolved
@willschlitzer @seisman
Apply suggestions from code review
e26f825 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
yvonnefroehlich
yvonnefroehlich reviewed Oct 5, 2022
View reviewed changes
pygmt/src/coast.py Outdated Show resolved Hide resolved
@willschlitzer @yvonnefroehlich
Update pygmt/src/coast.py
44e4f83 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@willschlitzer willschlitzer added the final review call This PR requires final review and approval from a second reviewer label Oct 5, 2022
@willschlitzer willschlitzer merged commit de984aa into main Oct 7, 2022
@willschlitzer willschlitzer deleted the inline-example/coast branch October 7, 2022 22:45
@willschlitzer willschlitzer removed the final review call This PR requires final review and approval from a second reviewer label Nov 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @seisman @yvonnefroehlich
Add inline example for coast (GenericMappingTools#2142)
b92e663 
* Update coast.py to include inline example in docstring

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

@willschlitzer willschlitzer

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@willschlitzer @seisman @michaelgrund @yvonnefroehlich