Add ternary sample dataset #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #2138.
|
/format |
|
The name definitions are open for discussion. |
|
@michaelgrund Can you add a test to |
|
/format |
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
seisman
reviewed
Nov 30, 2022
seisman
reviewed
Dec 2, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
/format |
|
I guess that all tests fail is related to the issue discussed in #2200, right? |
seisman
reviewed
Dec 2, 2022
seisman
reviewed
Dec 2, 2022
Python 3.8 tests should pass. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
/format |
seisman
reviewed
Dec 4, 2022
seisman
reviewed
Dec 4, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Dec 4, 2022
seisman
added
the
final review call
willschlitzer
approved these changes
Dec 4, 2022
seisman
removed
the
final review call
This was referenced Dec 5, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2138.
Description of proposed changes
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version