Add load_earth_free_air_anomaly function for Earth free-air anomaly dataset #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
changed the title
seisman
reviewed
Dec 10, 2022
Comment on lines
+11
to
+28
| def test_earth_faa_fails(): | ||
| """ | ||
| Make sure earth_free_air_anomaly fails for invalid resolutions. | ||
| """ | ||
| resolutions = "1m 1d bla 60d 001m 03".split() | ||
| resolutions.append(60) | ||
| for resolution in resolutions: | ||
| with pytest.raises(GMTInvalidInput): | ||
| load_earth_free_air_anomaly(resolution=resolution) | ||
|
|
||
|
|
||
| def test_earth_faa_incorrect_registration(): | ||
| """ | ||
| Test loading earth_free_air_anomaly with incorrect registration type. | ||
| """ | ||
| with pytest.raises(GMTInvalidInput): | ||
| load_earth_free_air_anomaly(registration="improper_type") | ||
|
|
There was a problem hiding this comment.
These tests are common to all Earth datasets. Perhaps we can move all these tests in a new test file like test_datasets_load_remote_dataset.py instead.
There was a problem hiding this comment.
This can be done in a separate PR if necessary.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Dec 13, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Dec 14, 2022
|
@willschlitzer This PR looks good to me, but need to resolve the conflicts before adding the "final review call" label. |
willschlitzer
added
the
final review call
michaelgrund
approved these changes
Dec 15, 2022
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
willschlitzer
removed
the
final review call
13 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ataset (GenericMappingTools#2238) * Add earth_free_air_anomaly.py * Add load_earth_free_air_anomaly to API index * Add tests and cache files for load_earth_free_air_anomaly Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
load_earth_free_air_anomalyto load the IGPP Global Earth Free-Air Anomaly dataset.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version