-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_earth_relief now can load gebco, gebcosi and synbath datasets with GMT 6.3 #2281
Conversation
It seems there are some failures in the GMT Legacy Tests, some are caused by the missing IPython package and some are doctests. But at least the tests with gebco/gebcosi/synbath now pass. |
Some TODOs:
|
Maybe do this after the PyGMT v0.8.0 release? We'll just manually verify this for now, so that the release isn't delayed any longer.
Opened PR at #2283 to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes should be ok. Maybe it's easier to merge this PR first, and then we can run the GMT Legacy Tests properly in #2283.
Description of proposed changes
As mentioned in #2225 (comment), after PR #2266 is merged, gebco, gebcosi and synbath dataset should work with GMT 6.3. This PR remove the exception when gebco/gebcosi/synbath datasets are used with GMT 6.3.
Fixes #2225.
Notes that:
Some tests fail with GMT 6.3 in the GMT Legacy Tests workflow (https://github.com/GenericMappingTools/pygmt/actions/runs/3784213311). These tests should pass after the changes in this PR.
Let's see the workflow results trigged by this PR https://github.com/GenericMappingTools/pygmt/actions/runs/3795048765.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version