-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example for scatter plot with histograms on sides #2410
Conversation
/format |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
/format |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
I have undone the changes regarding |
/format |
I think what you should use is |
/format |
Is the chosen "Histograms" category the right one for this example @GenericMappingTools/pygmt-maintainers ? |
I think the (more) interesting part of this figure are the histograms at the sides (not the scatter plot in the center), thus I would leave it as is in the "Histograms" category. There is also already a stand-alone gallery example for a Scatter plot. |
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example! Just two minor suggestions.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
This PR adds a new gallery example showing a combination of a scatter plot with histograms on the sides. This is often used but I found no documentation in the GMT universe for this use-case. Inspired by matplotlib.
Preview: https://pygmt-dev--2410.org.readthedocs.build/en/2410/gallery/histograms/scatter_and_histograms.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version