Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand gallery example "Focal mechanisms" to use "*fill" and "pen" #2433

Merged
merged 13 commits into from
Mar 20, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Mar 16, 2023

Description of proposed changes

This PR aims to extend the gallery example Focal mechanisms to use the parameters compressionfill, extensionfill, and pen added in PR #2345.

Preview: https://pygmt-dev--2433.org.readthedocs.build/en/2433/gallery/seismology/meca.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added the enhancement Improving an existing feature label Mar 16, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.9.0 milestone Mar 16, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Mar 16, 2023
@yvonnefroehlich yvonnefroehlich marked this pull request as draft March 16, 2023 08:36
@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review March 19, 2023 17:31
@yvonnefroehlich yvonnefroehlich added the needs review This PR has higher priority and needs review. label Mar 19, 2023
@yvonnefroehlich yvonnefroehlich changed the title WIP: Expand gallery example "Focal mechanisms" to use "*fill" and "pen" Expand gallery example "Focal mechanisms" to use "*fill" and "pen" Mar 20, 2023
@seisman seisman merged commit cf95e5a into main Mar 20, 2023
@seisman seisman deleted the expand-gallery-meca branch March 20, 2023 13:41
@seisman seisman added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants