Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove the deprecated cml-publish command from the dvc-diff workflow #2559

Merged
merged 3 commits into from
Jun 1, 2023
Merged

CI: Remove the deprecated cml-publish command from the dvc-diff workflow #2559

merged 3 commits into from
Jun 1, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 1, 2023 •
edited
Loading

Description of proposed changes

Remove the deprecated cml-publish command and refactor the workflow.

Address the following warning:

"cml publish" is deprecated since "cml comment" now supports "![inline](./asset.png)"

TODO:

  • revert the changes in commit aa4bedc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_basemap_added.png
deleted pygmt/tests/baseline/test_basemap_loglog.png
modified pygmt/tests/baseline/test_basemap.png

Image diff(s)

Added images

  • test_basemap_added.png

Modified images

Path Old New
test_basemap.png

Report last updated at commit a9727dd

@seisman seisman force-pushed the new-dvc-diff-workflow branch from 767aa1e to 894b8ce Compare June 1, 2023 04:16
@seisman seisman force-pushed the new-dvc-diff-workflow branch from 894b8ce to a9727dd Compare June 1, 2023 04:35
@seisman seisman marked this pull request as ready for review June 1, 2023 04:51
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Jun 1, 2023
@seisman seisman added this to the 0.10.0 milestone Jun 1, 2023
@seisman seisman requested a review from weiji14 June 1, 2023 05:09
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jun 1, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 1, 2023
@seisman seisman merged commit 5fa3b6e into main Jun 1, 2023
@seisman seisman deleted the new-dvc-diff-workflow branch June 1, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seisman @michaelgrund @weiji14