Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure.savefig: Support .jpeg as JPEG image extension #2691

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Figure.savefig: Support .jpeg as JPEG image extension #2691

merged 6 commits into from
Sep 19, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 15, 2023 •
edited
Loading

Support .jpeg as file extension. Please note that gmt psconvert -Tj always produces images with the .jpg extension. It has two downsides:

  1. Users may be surprised that they give .jpeg but get .jpg
  2. show=True won't work unless we change the codes

I feel it's better to rename the files to have the file extension that users expect.

Closes #2689.

@seisman seisman added enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog labels Sep 15, 2023
@seisman seisman added this to the 0.11.0 milestone Sep 15, 2023
@seisman seisman added needs review This PR has higher priority and needs review. and removed skip-changelog Skip adding Pull Request to changelog labels Sep 15, 2023
yvonnefroehlich
yvonnefroehlich reviewed Sep 17, 2023
View reviewed changes
pygmt/figure.py Outdated Show resolved Hide resolved
@seisman @yvonnefroehlich
Update pygmt/figure.py
8f1d1e3 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman requested a review from a team September 18, 2023 02:42
@seisman seisman changed the title Support .jpeg as JPEG image extension Figure.savefig: Support .jpeg as JPEG image extension Sep 18, 2023
@seisman
Copy link
Member Author

seisman commented Sep 18, 2023 •
edited
Loading

I've revised the codes so that it's much easier to support upper-case extensions (#2683) with very few code changes. Please review again.

@seisman seisman requested review from weiji14 and a team September 18, 2023 04:17
weiji14
weiji14 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding back the inline comment from ext = ext[1:] # Remove the . before.

pygmt/figure.py Outdated Show resolved Hide resolved
@seisman @weiji14
Update pygmt/figure.py
a9c4c1b 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Sep 19, 2023
@seisman seisman merged commit efb3c62 into main Sep 19, 2023
15 of 16 checks passed
@seisman seisman deleted the support-jpeg branch September 19, 2023 14:52
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich left review comments

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
enhancement Improving an existing feature
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Support "jpeg" as file extension
3 participants
@seisman @weiji14 @yvonnefroehlich