NEP29: Set minimum required version to NumPy 1.23+ #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Jan 12, 2024
| @@ -7,7 +7,7 @@ dependencies: | |||
| - python=3.12 | |||
| - gmt=6.5.0 | |||
| - ghostscript=10.02.1 | |||
| - numpy>=1.22 | |||
There was a problem hiding this comment.
Removing the numpy version information from this file, so that we have one fewer file to update next time.
There was a problem hiding this comment.
Ok, using >=1.22 might mean the latest numpy version is pulled in anyways.
weiji14
approved these changes
Jan 15, 2024
| @@ -7,7 +7,7 @@ dependencies: | |||
| - python=3.12 | |||
| - gmt=6.5.0 | |||
| - ghostscript=10.02.1 | |||
| - numpy>=1.22 | |||
There was a problem hiding this comment.
Ok, using >=1.22 might mean the latest numpy version is pulled in anyways.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Following NEP29 policy where NumPy 1.22 is to be dropped on or after 1 Jan 2024 (in a minor version increment, i.e. for PyGMT v0.11.0). Bumps minimum supported NumPy version to 1.23 in the pyproject.toml, requirements.txt and environment.yml files. Also update installation documentation to mention NumPy 1.22+ requirement.
This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.10.0/maintenance.html#dependencies-policy.
Supersedes #2586