-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Build GMT dev source code with OpenMP enabled on Linux and GThreads enabled on Linux/macOS #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
ci/tests-dev
branch
4 times, most recently
from
January 17, 2024 11:59
ad36720
to
818c2f4
Compare
seisman
changed the title
CI: Building GMT dev with OpenMP support
CI: Build GMT dev source codes with OpenMP support
Feb 3, 2024
seisman
changed the title
CI: Build GMT dev source codes with OpenMP support
CI: Build GMT dev source codes with OpenMP support on Linux
Apr 16, 2024
seisman
force-pushed
the
ci/tests-dev
branch
3 times, most recently
from
April 16, 2024 05:00
334d8c1
to
cfdd83c
Compare
seisman
force-pushed
the
ci/tests-dev
branch
4 times, most recently
from
May 21, 2024 00:28
905d587
to
b07b3c9
Compare
…ds enabled on Linux/macOS
seisman
changed the title
CI: Build GMT dev source codes with OpenMP support on Linux
CI: Build GMT dev source code with OpenMP enabled on Linux and GThreads enabled on Linux/macOS
May 21, 2024
seisman
added
maintenance
Boring but important stuff for the core devs
needs review
This PR has higher priority and needs review.
labels
May 21, 2024
weiji14
reviewed
May 21, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable GThreads support (currently only used by grdfilter) on Linux/macOS and OpenMP support on Linux.
OpenMP is not enabled on macOS, because currently we still fail to let cmake find and link the openmp library on macOS (see GenericMappingTools/gmt#1926).
After this PR, the number of failing tests is reduced from 5(Linux)/5(macOS)/1(Windows) to 1(Linux)/4(macOS)/1(Windows).