Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build GMT dev source code with OpenMP enabled on Linux and GThreads enabled on Linux/macOS #3011

Merged
merged 3 commits into from
May 21, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 17, 2024

Enable GThreads support (currently only used by grdfilter) on Linux/macOS and OpenMP support on Linux.

OpenMP is not enabled on macOS, because currently we still fail to let cmake find and link the openmp library on macOS (see GenericMappingTools/gmt#1926).

After this PR, the number of failing tests is reduced from 5(Linux)/5(macOS)/1(Windows) to 1(Linux)/4(macOS)/1(Windows).

@seisman seisman added the run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR label Jan 17, 2024
@seisman seisman force-pushed the ci/tests-dev branch 4 times, most recently from ad36720 to 818c2f4 Compare January 17, 2024 11:59
@seisman seisman mentioned this pull request Jan 27, 2024
32 tasks
@seisman seisman changed the title CI: Building GMT dev CI: Building GMT dev with OpenMP support Feb 3, 2024
@seisman seisman changed the title CI: Building GMT dev with OpenMP support CI: Build GMT dev source codes with OpenMP support Feb 3, 2024
@seisman seisman changed the title CI: Build GMT dev source codes with OpenMP support CI: Build GMT dev source codes with OpenMP support on Linux Apr 16, 2024
@seisman seisman force-pushed the ci/tests-dev branch 3 times, most recently from 334d8c1 to cfdd83c Compare April 16, 2024 05:00
@seisman seisman force-pushed the ci/tests-dev branch 4 times, most recently from 905d587 to b07b3c9 Compare May 21, 2024 00:28
@seisman seisman changed the title CI: Build GMT dev source codes with OpenMP support on Linux CI: Build GMT dev source code with OpenMP enabled on Linux and GThreads enabled on Linux/macOS May 21, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels May 21, 2024
@seisman seisman added this to the 0.13.0 milestone May 21, 2024
@seisman seisman marked this pull request as ready for review May 21, 2024 01:06
.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
.github/workflows/ci_tests_dev.yaml Outdated Show resolved Hide resolved
seisman and others added 2 commits May 21, 2024 14:12
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman removed the needs review This PR has higher priority and needs review. label May 21, 2024
@seisman seisman removed the run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR label May 21, 2024
@seisman seisman merged commit e17a1bf into main May 21, 2024
6 of 9 checks passed
@seisman seisman deleted the ci/tests-dev branch May 21, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants