-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Support typesetting apostrophe (') and backtick (`) #3105
Open
seisman
wants to merge
10
commits into
main
Choose a base branch
from
quotes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit 94092b4 |
michaelgrund
approved these changes
Mar 13, 2024
michaelgrund
added
final review call
This PR requires final review and approval from a second reviewer
needs review
This PR has higher priority and needs review.
and removed
final review call
This PR requires final review and approval from a second reviewer
labels
Mar 13, 2024
10 tasks
seisman
changed the title
Better support for single quotation and double quotation marks ('"‘’“”)
BREAKING: Support typesetting apostrophe (') and backtick (`)
Dec 2, 2024
seisman
added
needs review
This PR has higher priority and needs review.
discussions
Need more discussion before taking further actions
labels
Dec 2, 2024
seisman
added
enhancement
Improving an existing feature
and removed
discussions
Need more discussion before taking further actions
labels
Dec 2, 2024
seisman
commented
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3476 for context.
As explained in #3476, currently, we can't typeset the original apostrophes and backticks because they're mapped to
‘’
in PostScript. This PR adds the patch to support typesetting apostrophes and backticks.Please note that this is a breaking change. The main motivation of this PR is to ensure what you type is what you get (WYTIWIG, similar to WYSIWIG). So I think it's breaking things in a good way.
See the script and images below for the changes:
Fixes #3476.