-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change py.test to pytest #338
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider it done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic! Now 2 more things left to do:
-
You'll need to edit your initial post, and change the 'Fixes #' to 'Fixes [Easy typo fix] #dropthedot from py.test #336' so that the issue will be automatically closed when we merge in that pull request.
-
Update your branch by clicking on the "Update branch" buttonOops, you beat me to it!
Oh, and you might want to change the title to Change py.test to pytest
since it's not just the CONTRIBUTING.md file you're changing anymore.
Done and Done! |
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
Awesome work @Dovacody! Just a small tip for your next Pull Request - make your changes on a 'patch' branch instead of working on the 'master' branch, as that could be problematic for fast moving projects that merge into 'master' often. Other than that, I hope you learnt something helpful today 😄 |
Description of proposed changes
After Careful review of the CONTRIBUTING.MD file, I found a typo on concerning pytest. Easy fix
Fixes #336
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.