Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency of netCDF4 #3643

Draft
wants to merge 134 commits into
base: main
Choose a base branch
from
Draft

Remove the dependency of netCDF4 #3643

wants to merge 134 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 22, 2024

Description of proposed changes

Inspired by #3639 (comment), now it's possible to remove the netCDF4 package from PyGMT's dependency list.

Need to wait for #3115 and #3673 first.

Preview:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

seisman and others added 30 commits March 20, 2024 11:00
Minimal xarray.DataArray output with data and coordinates, no metadata yet.
Extra metadata from the _GMT_GRID_HEADER struct.
Reorder the dimensions to follow Channel, Height, Width (CHW) convention. Also added doctest checking output DataArray object and the image's x and y coordinates.
Get the registration and gtype info from the grid header and apply it to the GMT accessor attributes.
Trying to match some of the doctests in _GMT_GRID.
Remove hardcoded attribute that was only meant for NetCDF files, so that GeoTIFF files won't have it.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman changed the base branch from main to feature/read December 9, 2024 10:10
@seisman seisman changed the base branch from feature/read to main December 9, 2024 11:12
@seisman seisman changed the title Remove netCDF4 to see how if affects our tests Remove the dependency of netCDF4 Dec 9, 2024
@seisman seisman mentioned this pull request Dec 19, 2024
49 tasks
@weiji14 weiji14 added this to the 0.15.0 milestone Dec 19, 2024
@weiji14 weiji14 mentioned this pull request Dec 30, 2024
9 tasks
@seisman seisman removed this from the 0.15.0 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants