Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff's EM (flake8-errmsg) rules and fix violations #3661

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 29, 2024

Description of proposed changes

This PR enables ruff's EM rules and fixes some violations.

Address #2741.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 29, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 29, 2024
@seisman seisman removed the skip-changelog Skip adding Pull Request to changelog label Nov 29, 2024
pygmt/io.py Outdated Show resolved Hide resolved
pygmt/src/meca.py Show resolved Hide resolved
pygmt/clib/session.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Nov 29, 2024
pygmt/datasets/earth_relief.py Outdated Show resolved Hide resolved
pygmt/src/grd2xyz.py Outdated Show resolved Hide resolved
pygmt/src/grd2xyz.py Outdated Show resolved Hide resolved
pygmt/src/plot.py Outdated Show resolved Hide resolved
pygmt/src/plot3d.py Outdated Show resolved Hide resolved
pygmt/src/project.py Outdated Show resolved Hide resolved
pygmt/src/text.py Outdated Show resolved Hide resolved
pygmt/src/velo.py Outdated Show resolved Hide resolved
pygmt/src/grdtrack.py Outdated Show resolved Hide resolved
pygmt/src/grd2cpt.py Outdated Show resolved Hide resolved
pygmt/src/x2sys_cross.py Outdated Show resolved Hide resolved
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
pygmt/clib/session.py Outdated Show resolved Hide resolved
@seisman seisman merged commit 1633a18 into main Nov 30, 2024
21 checks passed
@seisman seisman deleted the ruff/EM branch November 30, 2024 06:39
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants