Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos OGC:WGS84 to OGC:CRS84 #3669

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix typos OGC:WGS84 to OGC:CRS84 #3669

merged 1 commit into from
Dec 4, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 3, 2024

There is no OGC:WGS84, only OGC:CRS84. This PR fixes the typos.

@weiji14 Are there any specific reasons that we use "OGC:CRS84", not EPSG:4326?

ChatGPT tells me:

The difference between OGC:CRS84 and EPSG:4326 lies in the order of their coordinate axes, even though both reference the same geographic coordinate system (WGS 84).

Key Differences:

  1. Coordinate Order:

    • OGC:CRS84: The order of coordinates is longitude, latitude (X, Y).
    • EPSG:4326: The order of coordinates is latitude, longitude (Y, X).
  2. Origin and Usage:

    • OGC:CRS84: Defined by the Open Geospatial Consortium (OGC) and primarily used in GeoJSON and other web mapping standards.
    • EPSG:4326: Defined by the EPSG registry and widely used in GIS software and spatial databases.
  3. Use Cases:

    • OGC:CRS84 is commonly used in web applications (e.g., GeoJSON), where the convention follows the Cartesian coordinate system's ordering (X, Y).
    • EPSG:4326 is used in traditional GIS applications and standards, aligning with the geographic convention of latitude before longitude (Y, X).

Practical Implications:

  • When working with data, it's crucial to respect the coordinate order expected by the software or standard you’re using.
  • Interoperability: If you interchange data between systems expecting different orders (e.g., GeoJSON vs. a GIS application), you might need to swap the coordinate values.

Visual Comparison:

If a point is located at 40° latitude and -75° longitude:

  • OGC:CRS84: [-75.0, 40.0] (longitude, latitude)
  • EPSG:4326: [40.0, -75.0] (latitude, longitude)

Despite the axis order difference, the spatial reference system and geodetic model (WGS 84) are identical for both.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
renamed pygmt/tests/baseline/test_tilemap_ogc_wgs84.png -> pygmt/tests/baseline/test_tilemap_ogc_crs84.png

Image diff(s)

Added images

Modified images

Path Old New

Report last updated at commit 5e16a3f

@seisman seisman added documentation Improvements or additions to documentation needs review This PR has higher priority and needs review. labels Dec 3, 2024
@seisman seisman requested a review from weiji14 December 3, 2024 12:33
@seisman seisman added this to the 0.14.0 milestone Dec 3, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiji14 Are there any specific reasons that we use "OGC:CRS84", not EPSG:4326?

Yes, it is the difference between lon/lat and lat/lon order. A lot of GIS software has been lenient around EPSG:4326 for lon/lat data because so many people use it that way, but it is technically wrong, and I think PROJ and other libraries will slowly become more stricter on this - e.g.:

@seisman seisman merged commit 5c2c631 into main Dec 4, 2024
23 of 25 checks passed
@seisman seisman deleted the typo/ogc branch December 4, 2024 01:50
@seisman seisman added skip-changelog Skip adding Pull Request to changelog and removed needs review This PR has higher priority and needs review. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants