Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut Windows CI build time in half to 15 min #586

Merged
merged 2 commits into from
Sep 5, 2020
Merged

Cut Windows CI build time in half to 15 min #586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
593f526
Bump setup-miniconda from 1.6.0 to 1.7.0
weiji14 Sep 5, 2020
165a9e9
Use latest miniconda-version instead of github actions bundled runner
weiji14 Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ jobs:

# Setup Miniconda
- name: Setup Miniconda
uses: goanpeca/setup-miniconda@v1.6.0
uses: conda-incubator/setup-miniconda@v1.7.0
with:
python-version: ${{ matrix.python-version }}
channels: conda-forge
miniconda-version: "latest"
Copy link
Member Author

@weiji14 weiji14 Sep 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll like this @seisman, The Windows conda install step speed up (~24min -> ~8min) comes from just adding this one line! What it does (on Windows) is to update the miniconda version from 4.6.14 to 4.8.3, and this would use a newer/faster conda solver, among other things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also speed up macOS. Perhaps we should also update ci_tests_dev.yaml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really by much, I think we can do it another time since that’s not really a bottleneck.


# Install GMT and other required dependencies from conda-forge
- name: Install GMT and required dependencies
Expand Down